Skip to content

[MRF-16] PLU-520: style approve/reject steps, show approval tag for yes/no #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pregnantboy wants to merge 1 commit into
base: mrf/support-reordering
Choose a base branch
from
Open

[MRF-16] PLU-520: style approve/reject steps, show approval tag for yes/no #1344

pregnantboy wants to merge 1 commit into from

Conversation

@pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented Nov 27, 2025 •
edited
Loading

Changes

  • Added an approval field type to FormSG data output metadata
  • Modified the flow creation process to no longer create an empty action step by default
  • Enhanced the AddStepButton component with better styling for approval branches
  • Added support for approval variables in the VariablesList component
  • Improved the MRF context to properly handle approval branches and reset state when approval steps change
  • Reduced the vertical spacing in the flow editor for a more compact layout

This was referenced Nov 27, 2025
Open
Closed
Open
Open
Open
Open
Open
Open
@pregnantboy Graphite App
Copy link
Contributor Author

pregnantboy commented Nov 27, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 27, 2025
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@pregnantboy pregnantboy force-pushed the mrf/show-approval-yesno-tag branch from b9ad250 to 1ac2ea2 Compare November 27, 2025 10:59
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Nov 27, 2025 •
edited
Loading

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 45e29cf | Docs | Was this helpful? Give us feedback!

@pregnantboy pregnantboy force-pushed the mrf/show-approval-yesno-tag branch from 1ac2ea2 to d40efe9 Compare November 29, 2025 16:30
@pregnantboy pregnantboy force-pushed the mrf/support-reordering branch 2 times, most recently from 157d86c to d4dbe67 Compare November 30, 2025 08:19
@pregnantboy pregnantboy force-pushed the mrf/show-approval-yesno-tag branch 2 times, most recently from ffdeed5 to d74b36f Compare November 30, 2025 08:56
@pregnantboy pregnantboy force-pushed the mrf/support-reordering branch 2 times, most recently from 09e5433 to 1607f0f Compare November 30, 2025 09:19
@pregnantboy pregnantboy force-pushed the mrf/show-approval-yesno-tag branch from d74b36f to 5c29b96 Compare November 30, 2025 09:19
@pregnantboy pregnantboy mentioned this pull request Nov 30, 2025
Open
@pregnantboy pregnantboy force-pushed the mrf/support-reordering branch from 1607f0f to a1a05eb Compare November 30, 2025 09:44
@pregnantboy pregnantboy force-pushed the mrf/show-approval-yesno-tag branch from 5c29b96 to aef82e6 Compare November 30, 2025 09:44
@pregnantboy pregnantboy changed the title chore: show approval tag, and fix some frontend stuff [MRF-14] PLU-520: Nov 30, 2025
@linear
Copy link

linear bot commented Nov 30, 2025

PLU-520 MRF: Approvals

@pregnantboy pregnantboy changed the title [MRF-14] PLU-520: [MRF-14] PLU-520: style approve/reject steps, show approval tag for yes/no Nov 30, 2025
@pregnantboy pregnantboy changed the title [MRF-14] PLU-520: style approve/reject steps, show approval tag for yes/no [MRF-16] PLU-520: style approve/reject steps, show approval tag for yes/no Nov 30, 2025
@pregnantboy pregnantboy force-pushed the mrf/support-reordering branch from a1a05eb to a066952 Compare November 30, 2025 10:53
@pregnantboy pregnantboy force-pushed the mrf/show-approval-yesno-tag branch 2 times, most recently from 0a42ced to ff00e1a Compare November 30, 2025 17:26
@pregnantboy pregnantboy force-pushed the mrf/support-reordering branch 2 times, most recently from 6744420 to cfcfdee Compare December 3, 2025 10:55
@pregnantboy pregnantboy force-pushed the mrf/show-approval-yesno-tag branch 2 times, most recently from 413b044 to 65a2c41 Compare December 3, 2025 15:42
@pregnantboy pregnantboy force-pushed the mrf/support-reordering branch 2 times, most recently from 0a77185 to f6c3b1e Compare December 3, 2025 15:45
@pregnantboy pregnantboy force-pushed the mrf/show-approval-yesno-tag branch from 65a2c41 to 37c8abc Compare December 3, 2025 15:45
@pregnantboy pregnantboy force-pushed the mrf/support-reordering branch from f6c3b1e to a4e791f Compare December 3, 2025 16:09
@pregnantboy pregnantboy force-pushed the mrf/show-approval-yesno-tag branch from 37c8abc to 45e29cf Compare December 3, 2025 16:09
@pregnantboy pregnantboy marked this pull request as ready for review December 3, 2025 16:24
@pregnantboy pregnantboy requested a review from a team as a code owner December 3, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pregnantboy